Skip to content

fix: incoming webhook "Post As" field not updating userId #35795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 8 commits into from
Apr 17, 2025
Merged

fix: incoming webhook "Post As" field not updating userId #35795

kodiakhq merged 8 commits into from
Apr 17, 2025

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Apr 14, 2025 •
edited by kody-ai bot
Loading

Proposed changes (including videos or screenshots)

Fixes the issue where updating the "Post As" field in the incoming webhook integration settings only changed the username and not the userId, resulting in messages being sent as the original user.

The integration now properly updates both username and userId to ensure the message sender reflects the selected user.

Issue(s)

Steps to test or reproduce

  1. Go to Administration → Integrations → Incoming Webhooks.
  2. Edit an existing webhook and change the "Post As" field to another valid user.
  3. Save and trigger the webhook.
  4. Confirm that the message is posted as the new selected user.

Further comments

CORE-1083

This pull request addresses an issue in the Rocket.Chat repository where the "Post As" field for incoming webhooks was not updating the userId correctly. The changes ensure that both username and userId are properly synchronized when the 'Post As' field is updated. The update includes a refactor of the channel validation logic into a new function validateChannels, improving code modularity and readability. Additionally, the handling of the associated user during integration updates is refined to modify username and userId only when explicitly provided. The findOneAndUpdate method is configured to return the updated document, which is a best practice. The changes also include adding the returnDocument option in the outgoing integration update method to ensure the updated document is returned after the update operation.

@abhinavkrin abhinavkrin requested a review from a team as a code owner April 14, 2025 11:19
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 14, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b6d51cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin added this to the 7.6.0 milestone Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (ae18eef) to head (b6d51cb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35795      +/-   ##
===========================================
- Coverage    60.99%   60.98%   -0.01%     
===========================================
  Files         2956     2956              
  Lines        70539    70539              
  Branches     16174    16174              
===========================================
- Hits         43022    43015       -7     
- Misses       24567    24573       +6     
- Partials      2950     2951       +1
Flag Coverage Δ
e2e 57.69% <ø> (-0.02%) ⬇️
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35795/

Built to branch gh-pages at 2025-04-16 22:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@kody-ai
Copy link

kody-ai bot commented Apr 15, 2025 •
edited
Loading

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 15, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@abhinavkrin
fix: incoming webhook "Post As" field not updating userId
1f2f9d0 
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin
added changeset
ad84068 
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin force-pushed the fix/incoming-webhook-post-as-not-updating-userid branch from 7ad512f to ad84068 Compare April 15, 2025 19:22
@abhinavkrin
modified tests
9fbc00b 
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin marked this pull request as draft April 16, 2025 06:31
@abhinavkrin abhinavkrin marked this pull request as ready for review April 16, 2025 06:31
@abhinavkrin abhinavkrin added the stat: QA assured Means it has been tested and approved by a company insider label Apr 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 16, 2025
@kody-ai
Copy link

kody-ai bot commented Apr 16, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 16, 2025 •
edited
Loading

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 16, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 16, 2025 •
edited
Loading

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 16, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kodiakhq kodiakhq bot merged commit dc6cf3e into develop Apr 17, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/incoming-webhook-post-as-not-updating-userid branch April 17, 2025 01:36
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Apr 20, 2025
Merged
@RocketChat RocketChat deleted a comment from dionisio-bot bot May 14, 2025
@abhinavkrin
Copy link
Member Author

abhinavkrin commented May 16, 2025

/backport 7.5.2

1 similar comment
@abhinavkrin
Copy link
Member Author

abhinavkrin commented May 19, 2025

/backport 7.5.2

@ggazzo
Copy link
Member

ggazzo commented May 19, 2025

/backport 7.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinavkrin @ggazzo @MarcosSpessatto